Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printf lint warning #742

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Fix printf lint warning #742

merged 2 commits into from
Sep 26, 2024

Conversation

estensen
Copy link
Contributor

@estensen estensen commented Sep 2, 2024

Why are these changes needed?

Running linter locally with a newer version than CI fails

❯ golangci-lint version
golangci-lint has version 1.60.3 built with go1.23.0 from c2e095c on 2024-08-22T21:45:24Z
❯ golangci-lint run ./...
api/errors.go:18:29: printf: non-constant format string in call to google.golang.org/grpc/status.Errorf (govet)
	return status.Errorf(code, msg)

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@jianoaix jianoaix merged commit 1649a25 into Layr-Labs:master Sep 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants