Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More fixes of quorum (uint8) stringification #731

Merged
merged 1 commit into from
Sep 1, 2024
Merged

More fixes of quorum (uint8) stringification #731

merged 1 commit into from
Sep 1, 2024

Conversation

jianoaix
Copy link
Contributor

@jianoaix jianoaix commented Aug 28, 2024 •
edited
Loading

Why are these changes needed?

string(num) doesn't work

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@jianoaix jianoaix requested review from dmanc and bxue-l2 August 28, 2024 20:33
@jianoaix jianoaix merged commit 372d5d2 into Layr-Labs:master Sep 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bxue-l2 bxue-l2 bxue-l2 approved these changes

@dmanc dmanc Awaiting requested review from dmanc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jianoaix @bxue-l2