Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ConfirmationTxnHash to feed blobs response #72

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Add ConfirmationTxnHash to feed blobs response #72

merged 2 commits into from
Dec 7, 2023

Conversation

wmb-software-consulting
Copy link
Contributor

@wmb-software-consulting wmb-software-consulting commented Nov 22, 2023 •
edited
Loading

Why are these changes needed?

Link to etherscan on blob explorer:

  • It would nice to be able to go to the chain from blobs.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@QuinnLee
Copy link

QuinnLee commented Dec 6, 2023

can this be merged?

@wmb-software-consulting wmb-software-consulting merged commit c5785ec into Layr-Labs:master Dec 7, 2023
4 checks passed
@wmb-software-consulting wmb-software-consulting deleted the feat/Add-ConfirmationTxnHash branch December 7, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ian-shim ian-shim ian-shim approved these changes

@jianoaix jianoaix jianoaix approved these changes

@QuinnLee QuinnLee QuinnLee approved these changes

@gpsanant gpsanant Awaiting requested review from gpsanant

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wmb-software-consulting @QuinnLee @jianoaix @ian-shim