[BatchConfirmer] Apply state transitions for full batches #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
commented
Aug 8, 2024
Comment on lines
-173
to
-181
| blobHeader := batchData.blobHeaders[blobIndex] | ||
|
|
||
| blobHeaderHash, err := blobHeader.GetBlobHeaderHash() | ||
| if err != nil { | ||
| b.logger.Error("failed to get blob header hash", "err", err) | ||
| blobsToRetry = append(blobsToRetry, batchData.blobs[blobIndex]) | ||
| continue | ||
| } | ||
| merkleProof, err := batchData.merkleTree.GenerateProof(blobHeaderHash[:], 0) |
There was a problem hiding this comment.
Proof should be generated based on leaf index, not the leaf data
ian-shim
commented
Aug 8, 2024
Comment on lines
+187
to
+194
| BatchHeaderHash: headerHash, | ||
| BlobIndex: uint32(blobIndex), | ||
| SignatoryRecordHash: core.ComputeSignatoryRecordHash(uint32(batchData.batchHeader.ReferenceBlockNumber), batchData.aggSig.NonSigners), | ||
| ReferenceBlockNumber: uint32(batchData.batchHeader.ReferenceBlockNumber), | ||
| BatchRoot: batchData.batchHeader.BatchRoot[:], | ||
| BlobInclusionProof: proof, | ||
| BlobCommitment: &batchData.blobHeaders[blobIndex].BlobCommitments, | ||
| // This is onchain, external batch ID, which is different from the internal representation of batch UUID |
There was a problem hiding this comment.
No change in this block. Just adding comment in L194
mooselumph
reviewed
Aug 9, 2024
pschork
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR makes
BatchConfirmertransition full batch state toFailedorAttested.It also improves the test coverage for batch confirmer.
Checks