Improve the log message in node #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianoaix
commented
Nov 20, 2023
| @@ -163,7 +163,6 @@ func (n *Node) Start(ctx context.Context) error { | |||
|
|
|||
| // Build the socket based on the hostname/IP provided in the CLI | |||
| socket := string(core.MakeOperatorSocket(n.Config.Hostname, n.Config.DispersalPort, n.Config.RetrievalPort)) | |||
| n.Logger.Info("Registering node with socket", "socket", socket) | |||
There was a problem hiding this comment.
This is misleading: it will not register if RegisterNodeAtStart is false (which is the default).
| @@ -358,6 +358,8 @@ func (n *Node) updateSocketAddress(ctx context.Context, newSocketAddr string) { | |||
| } | |||
|
|
|||
| func (n *Node) checkRegisteredNodeIpOnChain(ctx context.Context) { | |||
| n.Logger.Info("Start checkRegisteredNodeIpOnChain goroutine in background to subscribe the operator socket change events onchain") | |||
There was a problem hiding this comment.
Here and below: the start of an important routine
| @@ -207,12 +207,12 @@ func (n *Node) expireLoop() { | |||
| // least have 1 second. | |||
| timeLimitSec := uint64(math.Max(float64(n.Config.ExpirationPollIntervalSec)*gcPercentageTime, 1.0)) | |||
| numBatchesDeleted, err := n.Store.DeleteExpiredEntries(time.Now().Unix(), timeLimitSec) | |||
| n.Logger.Info("GC cycle deleted", "num batches", numBatchesDeleted) | |||
| n.Logger.Info("Complete an expiration cycle to remove expired batches", "num expired batches found and removed", numBatchesDeleted) | |||
There was a problem hiding this comment.
Expand what it's doing so it's clear for users reading the log.
dmanc
reviewed
Nov 20, 2023
node/node.go
Outdated
| @@ -193,8 +192,9 @@ func (n *Node) Start(ctx context.Context) error { | |||
| } | |||
|
|
|||
| // The expireLoop is a loop that is run once per configured second(s) while the node | |||
| // is running. It scans for expirated batches and remove them from the local database. | |||
| // is running. It scans for expired batches and remove them from the local database. | |||
ian-shim
approved these changes
Nov 20, 2023
|
Hi @jianoaix - sharing two requests for our log message improvements:
|
|
Thanks for feedback, these are good points. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Make it more clear what's happening in node based on feedback
Checks