Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name the ejection token to follow custom header format #553

Merged
merged 8 commits into from
May 10, 2024
Merged

Name the ejection token to follow custom header format #553

merged 8 commits into from
May 10, 2024

Conversation

jianoaix
Copy link
Contributor

@jianoaix jianoaix commented May 10, 2024 •
edited
Loading

Why are these changes needed?

The naming as "ejection_token" will be dropped.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@jianoaix jianoaix requested review from dmanc, anupsv and ian-shim May 10, 2024 21:05
@jianoaix jianoaix changed the title Name the ejection token to follow customer header format Name the ejection token to follow custom header format May 10, 2024
@jianoaix
Copy link
Contributor Author

It's odd this PR failed a unrelated test TestFetchRegisteredOperatorOnline. Debugging...

@jianoaix jianoaix merged commit 7ed64ce into Layr-Labs:master May 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmanc dmanc dmanc approved these changes

@anupsv anupsv anupsv approved these changes

@ian-shim ian-shim Awaiting requested review from ian-shim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jianoaix @anupsv @dmanc