Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secure conn in disperser client for GetBlobStatus #540

Merged
merged 1 commit into from
May 3, 2024

Conversation

ian-shim
Copy link
Contributor

@ian-shim ian-shim commented May 2, 2024

Why are these changes needed?

Addresses #538

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim requested review from mooselumph and jianoaix May 2, 2024 21:59
@ian-shim ian-shim marked this pull request as ready for review May 2, 2024 21:59
Comment on lines 206 to 208
if err != nil {
return nil, err
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate code

@ian-shim ian-shim force-pushed the dial-options-getblobstatus branch from 611898f to e54463f Compare May 3, 2024 17:28
@ian-shim ian-shim merged commit 8ec570b into Layr-Labs:master May 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants