Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set cache control for the dataapi responses #499

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Set cache control for the dataapi responses #499

merged 1 commit into from
Apr 19, 2024

Conversation

jianoaix
Copy link
Contributor

Why are these changes needed?

Cache the cache-able responses for scale and performance

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@jianoaix jianoaix requested review from antojoseph and dmanc April 19, 2024 00:54
antojoseph
antojoseph approved these changes Apr 19, 2024
View reviewed changes
Copy link

@antojoseph antojoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, lets verify this in holesky with caching

@jianoaix jianoaix merged commit 090db84 into Layr-Labs:master Apr 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmanc dmanc dmanc approved these changes

@antojoseph antojoseph antojoseph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jianoaix @antojoseph @dmanc