Remove encoded blob if confirmed #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
force-pushed
the
remove-confirmed-encoded-blob
branch
from
1abead7 to
02c1708
Compare
mooselumph
reviewed
Nov 17, 2023
ian-shim
force-pushed
the
remove-confirmed-encoded-blob
branch
from
02c1708 to
6906cf7
Compare
mooselumph
approved these changes
Nov 17, 2023
jianoaix
approved these changes
Nov 17, 2023
teddyknox
pushed a commit
that referenced
this pull request
Nov 29, 2023
Signed-off-by: Wellington Barbosa <[email protected]> Co-authored-by: Wellington Barbosa <[email protected]> Co-authored-by: gpsanant <[email protected]> Co-authored-by: Robert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
For a retry mechanism, we encode a blob again at different reference block number if the blob is in the middle of being dispersed because we don't know the status of that blob yet.
Once we know the blob has been dispersed successfully, we should remove it from the encoded blob store, so that we don't disperse the same blob again.
Checks