Add context on few error logs + early return on encoding streamer #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
changed the title
ian-shim
force-pushed
the
log-err-context
branch
from
5661da6 to
82576af
Compare
mooselumph
reviewed
Mar 25, 2024
mooselumph
reviewed
Mar 25, 2024
mooselumph
reviewed
Mar 25, 2024
disperser/cmd/batcher/main.go
Outdated
| @@ -190,6 +190,11 @@ func RunBatcher(ctx *cli.Context) error { | |||
| if err != nil { | |||
| return err | |||
| } | |||
| sender, err := wallet.SenderAddress(context.Background()) | |||
There was a problem hiding this comment.
Don't have a developed perspective on this, but if this is just used for logging, should we error out the function if we can't get it?
There was a problem hiding this comment.
Yeah this value is actually used for validation: https://github.com/Layr-Labs/eigenda/blob/master/disperser/cmd/batcher/main.go#L210
I'll rebase this one as the logging got added in another PR
mooselumph
approved these changes
Mar 25, 2024
ian-shim
force-pushed
the
log-err-context
branch
from
82576af to
83eca4a
Compare
ian-shim
force-pushed
the
log-err-context
branch
from
83eca4a to
5e6e835
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Few minor fixes and additional information on some error logs
Checks