Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Finalizer] Add check before processing ConfirmationInfo #341

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

siddimore
Copy link
Contributor

Why are these changes needed?

Blobs in Batch may have been marked as failed by ProcessConfirmedBatch after updateBlobs is called. This resulted in Batcher crashing prior to additional defensive checks being added.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@siddimore siddimore requested a review from ian-shim March 13, 2024 03:41
@siddimore siddimore marked this pull request as ready for review March 13, 2024 03:42
@siddimore siddimore merged commit dc76dce into Layr-Labs:master Mar 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants