Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing methods in EthClient interface #332

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

ian-shim
Copy link
Contributor

@ian-shim ian-shim commented Mar 9, 2024

Why are these changes needed?

Adding missing methods in EthClient to match the interface in eigensdk. This is necessary for integrating the hot wallet, which expects an eth client.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim requested review from dmanc and jianoaix March 9, 2024 03:26
@ian-shim ian-shim marked this pull request as ready for review March 9, 2024 03:26
@ian-shim ian-shim merged commit 28b4906 into Layr-Labs:master Mar 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants