Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DockerFile] Fix Churner Dockerbuild #307

Merged
merged 2 commits into from
Mar 2, 2024
Merged

[DockerFile] Fix Churner Dockerbuild #307

merged 2 commits into from
Mar 2, 2024

Conversation

siddimore
Copy link
Contributor

Why are these changes needed?

Fix path on Churner

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@siddimore siddimore requested review from jianoaix and ian-shim March 2, 2024 16:30
jianoaix
jianoaix approved these changes Mar 2, 2024
View reviewed changes
operators/churner/cmd/Dockerfile Outdated Show resolved Hide resolved
operators/churner/cmd/Dockerfile Outdated Show resolved Hide resolved
@jianoaix
Copy link
Contributor

jianoaix commented Mar 2, 2024

Also what's the test could be done before merging PR?

@siddimore siddimore requested review from dmanc and jianoaix March 2, 2024 18:38
@siddimore
Copy link
Contributor Author

siddimore commented Mar 2, 2024 •
edited
Loading

Also what's the test could be done before merging PR?

options for Test:

  1. add make which builds docker images locally
  2. do PR Docker builds

i vote for option2 this guarantees Dockerbuilds always work. When PR is merged we can publish the image

@siddimore siddimore merged commit 259a5e0 into Layr-Labs:master Mar 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ian-shim ian-shim Awaiting requested review from ian-shim

@dmanc dmanc Awaiting requested review from dmanc

@jianoaix jianoaix Awaiting requested review from jianoaix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siddimore @jianoaix