[4/N][multi quorum ejection] Create operator quorum intervals #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianoaix
commented
Mar 2, 2024
disperser/dataapi/nonsigner_utils.go
Outdated
|
|
||
| import "fmt" | ||
|
|
||
| type OperatorQuorum struct { |
There was a problem hiding this comment.
This will be removed once #293 is in.
…nsigning-quoruminterval
…nsigning-quoruminterval
ian-shim
approved these changes
Mar 7, 2024
| for i < len(added) && j < len(removed) { | ||
| // TODO(jianoaix): Having quorum addition and removal in the same block is a valid case. | ||
| // Come up a followup fix to handle this special case. | ||
| if added[i].BlockNumber == removed[j].BlockNumber { |
There was a problem hiding this comment.
Yeah we need to consider the transaction indexes of the transactions or the log index if they happened in the same transaction
There was a problem hiding this comment.
The idea in my mind was to make a RPC call to the eth node to get the quorums after applying all txns in a block, so we could avoid having to know the details inside a block. Quorum opt-in/out are not frequent events, even more so the opt-in/out happening in a same block, so should be small cost to handle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This is part of the work to compute operator nonsigning rate for ejection in multi quorum.
Roughly the other 50% of the second step in https://docs.google.com/document/d/13nxDXTAxRhT18qZrEkTtS2F7CxjlM0qA-2EGim1bu1k/edit (first 50% is #293)
Checks