Separate apiserver validation #279
Conversation
|
|
||
| securityParams := blob.RequestHeader.SecurityParams | ||
| if len(securityParams) == 0 { | ||
| return nil, fmt.Errorf("invalid request: security_params must not be empty") |
There was a problem hiding this comment.
These validation errors don't currently result in call to s.metrics.HandleFailedRequest(quorumId, blobSize, "DisperseBlob")
There was a problem hiding this comment.
The invalid requests may be just bogus
There was a problem hiding this comment.
What do you think of this? https://github.com/Layr-Labs/eigenda/pull/279/files#r1501257383
| s.logger.Debug("received a new blob request", "origin", origin, "securityParams", strings.Join(securityParamsStrings, ", ")) | ||
|
|
||
| if err := blob.RequestHeader.Validate(); err != nil { |
There was a problem hiding this comment.
We currently update the metrics for some validation errors but not others.
disperser/apiserver/server.go
Outdated
| for _, param := range securityParams { | ||
| quorumId := string(param.QuorumID) | ||
| s.metrics.HandleFailedRequest(quorumId, blobSize, "DisperseBlob") | ||
| } |
There was a problem hiding this comment.
I think we should just return the error without calling HandleFailedRequest as this would double count this blob in HandleFailedRequest. It's being counted in L263
There was a problem hiding this comment.
Oh, oops! Thanks!
Why are these changes needed?
Separate out apiserver request validation and improve metrics coverage.
Checks