Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm wrong validationa and expose log #250

Merged
merged 2 commits into from
Feb 7, 2024
Merged

rm wrong validationa and expose log #250

merged 2 commits into from
Feb 7, 2024

Conversation

bxue-l2
Copy link
Contributor

@bxue-l2 bxue-l2 commented Feb 7, 2024

Why are these changes needed?

This PR removes a wrong check that requires the G1 SRS size equal to the entire encoded blob size. It also exposes the encoder log.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@bxue-l2 bxue-l2 requested a review from ian-shim February 7, 2024 05:06
@bxue-l2 bxue-l2 merged commit c038525 into Layr-Labs:master Feb 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ian-shim ian-shim ian-shim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bxue-l2 @ian-shim