Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the API documentation #244

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Update the API documentation #244

merged 1 commit into from
Feb 6, 2024

Conversation

jianoaix
Copy link
Contributor

@jianoaix jianoaix commented Feb 6, 2024 •
edited
Loading

Why are these changes needed?

Docs are out of sync with the .proto API files.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@jianoaix jianoaix requested review from wesfloyd and ian-shim February 6, 2024 01:58
@wesfloyd
Copy link
Contributor

wesfloyd commented Feb 6, 2024

@teddyknox would you like for @jianoaix to include you on these future reviews for EigenDA?

ian-shim
ian-shim approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@ian-shim ian-shim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏 👏 👏

@jianoaix jianoaix merged commit 5fcba58 into Layr-Labs:master Feb 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ian-shim ian-shim ian-shim approved these changes

@wesfloyd wesfloyd Awaiting requested review from wesfloyd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jianoaix @wesfloyd @ian-shim