Churner fixes for m2 mainnet contracts #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
approved these changes
Feb 1, 2024
churner/churner.go
Outdated
| @@ -204,7 +204,7 @@ func (c *churner) getOperatorsToChurn(ctx context.Context, quorumIDs []uint8, op | |||
| churnBIPsOfOperatorStake := big.NewInt(int64(operatorSetParams.ChurnBIPsOfOperatorStake)) | |||
| churnBIPsOfTotalStake := big.NewInt(int64(operatorSetParams.ChurnBIPsOfTotalStake)) | |||
|
|
|||
| c.logger.Info("lowestStake", "lowestStake", lowestStake.String(), "operatorToRegisterStake", operatorToRegisterStake.String(), "totalStake", totalStake.String()) | |||
| c.logger.Info("lowestStake", "lowestStake", lowestStake.String(), "operatorToRegisterStake", operatorToRegisterStake.String(), "totalStake", totalStake.String(), "operatorToRegisterAddress", operatorToRegisterAddress) | |||
There was a problem hiding this comment.
operatorToRegisterAddress.Hex()
jianoaix
reviewed
Feb 1, 2024
| @@ -195,6 +195,7 @@ func (n *Node) Start(ctx context.Context) error { | |||
| return fmt.Errorf("NewClient: cannot parse private key: %w", err) | |||
| } | |||
| operator := &Operator{ | |||
| Address: crypto.PubkeyToAddress(privateKey.PublicKey).Hex(), | |||
There was a problem hiding this comment.
What's the bug in old code? It looks more like we drop the unnecessary flag for address, since address can be derived with private key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Small fixes to churner
Checks