-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use logfmt instead of terminal format #226
Conversation
We have a use case for terminal log: the nodeplugin used by the operators. May need to check the output there to make sure it's good. |
Good point, what do you think about making the format a config flag and make current behavior the default? |
SG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - we should work on using single log framework across repos.
Why are these changes needed?
Right now our logs look like this:
This is because we use "Terminal Format" which should really only be used in development.
Grafana will have an easier time parsing the log if we use logfmt (brandur.org):
Checks