[disperser] Return commitment as a struct #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
force-pushed
the
return-deserialized-commitment
branch
from
c28ab33 to
19ef534
Compare
ian-shim
force-pushed
the
return-deserialized-commitment
branch
from
19ef534 to
7929d22
Compare
ian-shim
changed the title
5 tasks
ian-shim
force-pushed
the
return-deserialized-commitment
branch
3 times, most recently
from
894ba5f to
f38cf8a
Compare
ian-shim
commented
Feb 5, 2024
api/proto/disperser/disperser.proto
Outdated
| @@ -179,6 +179,13 @@ enum BlobStatus { | |||
| INSUFFICIENT_SIGNATURES = 5; | |||
| } | |||
|
|
|||
| message Commitment { | |||
There was a problem hiding this comment.
Disperser API change
api/proto/node/node.proto
Outdated
| @@ -105,15 +105,33 @@ message Bundle { | |||
| repeated bytes chunks = 1; | |||
| } | |||
|
|
|||
| message G1Commitment { | |||
| @@ -121,10 +121,10 @@ func (b *BlobHeader) EncodedSizeAllQuorums() int64 { | |||
|
|
|||
| // BlomCommitments contains the blob's commitment, degree proof, and the actual degree. | |||
| type BlobCommitments struct { | |||
There was a problem hiding this comment.
BlobCommitments data structure change
| type Commitment struct { | ||
| *bn254.G1Point | ||
| } | ||
| type G1Commitment bn254.G1Point |
There was a problem hiding this comment.
G1Commitment & G2Commitment are typed as G1Point and G2Point.
They're not being type aliased so that we can add instance methods such as Serialize and Deserialize.
ian-shim
force-pushed
the
return-deserialized-commitment
branch
2 times, most recently
from
d7ed800 to
e449d6c
Compare
jianoaix
reviewed
Feb 5, 2024
ian-shim
force-pushed
the
return-deserialized-commitment
branch
from
e449d6c to
16230e2
Compare
ian-shim
force-pushed
the
return-deserialized-commitment
branch
from
16230e2 to
b319aaf
Compare
jianoaix
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In the external API, the commitment in blob header was being returned as serialized bytes. This serialization is done using
globlibrary which is part of go's standard library. For those using other languages, it would be difficult to deserialize these bytes withoutgloblibrary implemented in that language.Commitment,LengthCommitment, andLengthProofNote: this is a breaking change for rollups. While this kind of backward incompatible change in the API isn't ideal, this is added as an exception as we want to keep the API as close to what will be shipped on production (mainnet), and not many rollups have been integrated using the existing API yet.
Checks