fix(breaking): add storage gap to da service manager storage #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you considered making use of unstructured storage? This completely removes any storage management issues with upgradeable contracts. OpenZeppelin makes use of it now. |
Yeah, this is a good suggestion. Thanks for surfacing |
0x0aa0
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
EigenDAServiceManager storage needs a gap to prevent changes in its layout from pushing into the storage layout of contracts it inherits. This change adds the standard 50 storage slot buffer between each contract in the inheritance chain. Three are currently used, and 47 are appended to the end to account for future changes.
The attached screen shows the storage layout before and after to illustrate that the
__GAPwas needed after the three storage slots currently used by EigenDA to prevent shifting the entire storage layout if a new variable or mapping was added.