Create a dynamodb collector #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmanc
changed the title
ian-shim
reviewed
Jan 19, 2024
dmanc
changed the title
ian-shim
reviewed
Jan 22, 2024
Yeah I'll update the image. |
ian-shim
approved these changes
Jan 22, 2024
| } | ||
|
|
||
| func (collector *DynamoDBCollector) Collect(ch chan<- prometheus.Metric) { | ||
| count, err := collector.blobMetadataStore.GetBlobMetadataByStatusCount(context.Background(), disperser.Processing) |
There was a problem hiding this comment.
how do we make this track other statuses?
There was a problem hiding this comment.
I think we would add another value to the channel
ch <- prometheus.MustNewConstMetric(
collector.blobStatusMetric,
prometheus.GaugeValue,
float64(count), <- Different count
disperser.Processing.String(), <- Change to other status
)
There was a problem hiding this comment.
For this PR, gonna keep it scoped to just processing status. If we want to measure the other ones I'll create a PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
https://prometheus.io/docs/instrumenting/writing_exporters/#collectors
Allows us to add a metric for the number of blobs in the processing state.
Checks