Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix disperser client #186

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Fix disperser client #186

merged 1 commit into from
Jan 16, 2024

Conversation

ian-shim
Copy link
Contributor

@ian-shim ian-shim commented Jan 16, 2024 •
edited
Loading

Why are these changes needed?

Previously, disperser client was importing flags from github.com/Layr-Labs/eigenda/retriever/flags which may not be available from a host that's using the client.
It explicitly receives parameters to make the config.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim requested review from dmanc and mooselumph January 16, 2024 23:47
@ian-shim ian-shim marked this pull request as ready for review January 16, 2024 23:47
@ian-shim ian-shim merged commit bd5897e into Layr-Labs:master Jan 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmanc dmanc dmanc approved these changes

@mooselumph mooselumph Awaiting requested review from mooselumph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ian-shim @dmanc