Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Properly handle gas fee bumps #173

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Fix: Properly handle gas fee bumps #173

merged 1 commit into from
Jan 12, 2024

Conversation

ian-shim
Copy link
Contributor

@ian-shim ian-shim commented Jan 12, 2024 •
edited
Loading

Why are these changes needed?

  • We need to round up the gas fee increase so that we're always increasing it by more than 10%
  • We should track the new (replaced) transaction only if the replacement succeeded

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim marked this pull request as ready for review January 12, 2024 00:43
@ian-shim ian-shim force-pushed the roundup-gas-price-increase branch from 39c7bea to 7a3ffdf Compare January 12, 2024 00:56
@ian-shim ian-shim changed the title Round up gas fee increases Fix: Properly handle gas fee bumps Jan 12, 2024
@ian-shim ian-shim force-pushed the roundup-gas-price-increase branch from 7a3ffdf to 7a7ecb1 Compare January 12, 2024 01:12
siddimore
siddimore approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@siddimore siddimore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ian-shim ian-shim force-pushed the roundup-gas-price-increase branch from 7a7ecb1 to 300d223 Compare January 12, 2024 01:25
@ian-shim ian-shim merged commit 924685e into Layr-Labs:master Jan 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddimore siddimore siddimore approved these changes

@mooselumph mooselumph Awaiting requested review from mooselumph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ian-shim @siddimore