Use TxnManager for onchain transactions
#164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
force-pushed
the
batcher-use-txn-manager
branch
2 times, most recently
from
5bc6b43 to
0c9760e
Compare
mooselumph
reviewed
Jan 8, 2024
mooselumph
reviewed
Jan 9, 2024
| if err != nil { | ||
| return nil, fmt.Errorf("HandleSingleBatch: error getting batch header hash: %w", err) | ||
| } | ||
| batchID, err := b.getBatchID(ctx, txnReceipt) |
There was a problem hiding this comment.
This function requests a new receipt if the previous one doesn't contain the logs. Are the logs the only thing that may not be populated? I see that we are using the TxHash on L258. Assuming this will always be populated.
There was a problem hiding this comment.
Yes, TxHash will be populated as long as the txn has been published.
I've seen logs missing intermittently in some RPC endpoints when receipt is retrieved too soon
mooselumph
reviewed
Jan 9, 2024
| @@ -44,7 +44,7 @@ func (c *BatchConfirmer) ConfirmBatch(ctx context.Context, header *core.BatchHea | |||
| ctxWithTimeout, cancel := context.WithTimeout(ctx, c.timeout) | |||
| defer cancel() | |||
| for i := 0; i < maxRetries; i++ { | |||
| txReceipt, err = c.Transactor.ConfirmBatch(ctxWithTimeout, *header, quorums, *sigAgg) | |||
| txReceipt, err = c.Transactor.ConfirmBatch(ctxWithTimeout, header, quorums, sigAgg) | |||
There was a problem hiding this comment.
Looks like maybe we can remove this object?
There was a problem hiding this comment.
Yes, I'm planning on removing BatchConfirmer entirely once we've tested and validated TxnManager
mooselumph
approved these changes
Jan 9, 2024
mooselumph
approved these changes
Jan 9, 2024
ian-shim
force-pushed
the
batcher-use-txn-manager
branch
from
0c9760e to
541dcfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
TxnManagerto wait for transactions in a separate goroutinesconfirmationInfois updated in a separate goroutine as transaction receipt is now received asynchronouslyTODOs In following PRs:
TxnManagerChecks