Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation and error msg of the churner #114

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Improve documentation and error msg of the churner #114

merged 3 commits into from
Dec 12, 2023

Conversation

jianoaix
Copy link
Contributor

@jianoaix jianoaix commented Dec 8, 2023 •
edited
Loading

Why are these changes needed?

The churn logic is still confusing to users. This PR adds some documentation and improves the error message.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@jianoaix jianoaix requested a review from gpsanant December 8, 2023 04:53
@jianoaix jianoaix merged commit e6c7be0 into Layr-Labs:master Dec 12, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpsanant gpsanant gpsanant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jianoaix @gpsanant