Skip to content

Commit

Permalink
Minor logging update (#461)
Browse files Browse the repository at this point in the history
  • Loading branch information
ian-shim authored Apr 10, 2024
1 parent d766ffa commit b52bdcb
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
1 change: 0 additions & 1 deletion core/aggregation.go
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,6 @@ func (a *StdSignatureAggregator) AggregateSignatures(ctx context.Context, state
opInfo, ok := ops[r.Operator]
// If operator is not in quorum, skip
if !ok {
a.Logger.Error("Operator not found in quorum", "operatorID", operatorIDHex, "operatorAddress", operatorAddr, "socket", socket, "quorumID", quorumID)
continue
}
operatorQuorums = append(operatorQuorums, quorumID)
Expand Down
4 changes: 2 additions & 2 deletions disperser/common/blobstore/shared_storage.go
Original file line number Diff line number Diff line change
Expand Up @@ -137,12 +137,12 @@ func (s *SharedBlobStore) MarkBlobConfirmed(ctx context.Context, existingMetadat
// TODO (ian-shim): remove this check once we are sure that the metadata is never overwritten
refreshedMetadata, err := s.GetBlobMetadata(ctx, existingMetadata.GetBlobKey())
if err != nil {
s.logger.Error("[MarkBlobConfirmed] error getting blob metadata", "err", err)
s.logger.Error("error getting blob metadata", "err", err)
return nil, err
}
alreadyConfirmed, _ := refreshedMetadata.IsConfirmed()
if alreadyConfirmed {
s.logger.Warn("[MarkBlobConfirmed] trying to confirm blob already marked as confirmed", "blobKey", existingMetadata.GetBlobKey().String())
s.logger.Warn("trying to confirm blob already marked as confirmed", "blobKey", existingMetadata.GetBlobKey().String())
return refreshedMetadata, nil
}
newMetadata := *existingMetadata
Expand Down
2 changes: 1 addition & 1 deletion node/node.go
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ func (n *Node) Start(ctx context.Context) error {
socket := string(core.MakeOperatorSocket(n.Config.Hostname, n.Config.DispersalPort, n.Config.RetrievalPort))
if n.Config.RegisterNodeAtStart {
n.Logger.Info("Registering node on chain with the following parameters:", "operatorId",
n.Config.ID, "hostname", n.Config.Hostname, "dispersalPort", n.Config.DispersalPort,
n.Config.ID.Hex(), "hostname", n.Config.Hostname, "dispersalPort", n.Config.DispersalPort,
"retrievalPort", n.Config.RetrievalPort, "churnerUrl", n.Config.ChurnerUrl, "quorumIds", n.Config.QuorumIDList)
socket := string(core.MakeOperatorSocket(n.Config.Hostname, n.Config.DispersalPort, n.Config.RetrievalPort))
privateKey, err := crypto.HexToECDSA(n.Config.EthClientConfig.PrivateKeyString)
Expand Down

0 comments on commit b52bdcb

Please sign in to comment.