Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore give docker image fullname #119

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Chore give docker image fullname #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f9e3cc
chore: docker-build uses full ghcr image name
samlaf Sep 6, 2024
be53207
chore: clean dockerignore file
samlaf Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ COPY go.mod go.sum ./
# Download all dependencies. Dependencies will be cached if the go.mod and go.sum files are not changed
RUN go mod download

# Copy the rest of the application code
# Copy the rest of the application code (filtered by .dockerignore)
COPY . .

# Build the application binary
Expand Down
11 changes: 9 additions & 2 deletions Dockerfile.dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,9 @@
!/go.mod
!/go.sum
# Ignore everything
*

# Re-include necessary files only
!go.mod
!go.sum
!*/**/*.go
!Makefile
!resources
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
APP_NAME = eigenda-proxy
IMAGE_NAME = ghcr.io/layr-labs/eigenda-proxy
LINTER_VERSION = v1.52.1
LINTER_URL = https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh
GET_LINT_CMD = "curl -sSfL $(LINTER_URL) | sh -s -- -b $(go env GOPATH)/bin $(LINTER_VERSION)"
Expand All @@ -21,7 +21,7 @@ eigenda-proxy:

.PHONY: docker-build
docker-build:
@docker build -t $(APP_NAME) .
@docker build -t $(IMAGE_NAME) .

run-minio:
docker run -p 4566:9000 -d -e "MINIO_ROOT_USER=minioadmin" -e "MINIO_ROOT_PASSWORD=minioadmin" --name minio minio/minio server /data
Expand Down
Loading