feat(formatter)!: time()/date()/datetime() will accept only `st…

…ring` as `$format` name.
LastDragon-ru · Jan 1, 2024 · 5612367 · 5612367
1 parent 9bc90af
commit 5612367
Showing 1 changed file with 6 additions and 12 deletions.
diff --git a/packages/formatter/src/Formatter.php b/packages/formatter/src/Formatter.php
@@ -340,23 +340,23 @@ public function duration(DateInterval|float|int|null $value, string $format = nu
 
     public function time(
         ?DateTimeInterface $value,
-        string|int $format = null,
+        string $format = null,
         IntlTimeZone|DateTimeZone|string $timezone = null,
     ): string {
         return $this->formatDateTime(self::Time, $value, $format, $timezone);
     }
 
     public function date(
         ?DateTimeInterface $value,
-        string|int $format = null,
+        string $format = null,
         IntlTimeZone|DateTimeZone|string $timezone = null,
     ): string {
         return $this->formatDateTime(self::Date, $value, $format, $timezone);
     }
 
     public function datetime(
         ?DateTimeInterface $value,
-        string|int $format = null,
+        string $format = null,
         IntlTimeZone|DateTimeZone|string $timezone = null,
     ): string {
         return $this->formatDateTime(self::DateTime, $value, $format, $timezone);
@@ -501,7 +501,7 @@ protected function formatValue(
     protected function formatDateTime(
         string $type,
         ?DateTimeInterface $value,
-        string|int $format = null,
+        string $format = null,
         IntlTimeZone|DateTimeZone|string $timezone = null,
     ): string {
         if (is_null($value)) {
@@ -548,10 +548,7 @@ protected function formatFilesize(string|float|int|null $bytes, int $decimals, i
 
     // <editor-fold desc="Internal">
     // =========================================================================
-    private function getIntlDateFormatter(
-        string $type,
-        string|int $format = null,
-    ): IntlDateFormatter {
+    private function getIntlDateFormatter(string $type, string $format = null): IntlDateFormatter {
         $key       = json_encode([$type, $format], JSON_THROW_ON_ERROR);
         $formatter = $this->dateFormatters[$key] ?? $this->createIntlDateFormatter($type, $format);
 
@@ -564,10 +561,7 @@ private function getIntlDateFormatter(
         return $formatter;
     }
 
-    private function createIntlDateFormatter(
-        string $type,
-        string|int $format = null,
-    ): ?IntlDateFormatter {
+    private function createIntlDateFormatter(string $type, string $format = null): ?IntlDateFormatter {
         $formatter = null;
         $pattern   = '';
         $default   = IntlDateFormatter::SHORT;