Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap 4 breaks the table and dropdowns #169

Closed
sdaitzman opened this issue Aug 29, 2015 · 4 comments
Closed

Bootstrap 4 breaks the table and dropdowns #169

sdaitzman opened this issue Aug 29, 2015 · 4 comments
Assignees
@sdaitzman
Labels
!!
Milestone
0.0.6

Comments

@sdaitzman
Copy link
Contributor

Not touching this until 0.0.5 is done
@sdaitzman sdaitzman added the !! label Aug 29, 2015
@sdaitzman sdaitzman self-assigned this Aug 29, 2015
@sdaitzman sdaitzman added this to the 0.0.6 milestone Aug 29, 2015
sdaitzman pushed a commit that referenced this issue Sep 17, 2015
fixes table display on bootstrap 4
9be1513 
- it was wonky
- it isn’t wonky now
- partially fixes #169
@sdaitzman
Copy link
Contributor Author

Todo:

  • make dragging look pretty again

Done:

  • make delete confirmations work again
  • fix icon color
  • make login confirm button pretty again
  • make dropdowns pretty again
  • fix table
  • replace glyphicons with FontAwesome
  • get tooltips working again
  • fix log icon

@sdaitzman
Copy link
Contributor Author

134e56c adds the icons back, but they don't fully work.

@sdaitzman
Copy link
Contributor Author

twbs/bootstrap#17273 explains why the tooltips are broken. Fixing.

sdaitzman pushed a commit that referenced this issue Sep 17, 2015
includes tether on page
78aa78b 
fixes tooltips for #169
sdaitzman pushed a commit that referenced this issue Sep 17, 2015
makes form <select>s pretty again
fd685cf 
#169
sdaitzman pushed a commit that referenced this issue Sep 17, 2015
makes the auth confirm button pretty again
c2c657f 
#169
@sdaitzman
Copy link
Contributor Author

Closing and moving dragging and tooltip issues to two new issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdaitzman sdaitzman

Labels
!!
Projects
None yet
Milestone
0.0.6
Development

No branches or pull requests
1 participant
@sdaitzman