Improvement of onColorChanged notifications and color manipulation handling #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, circle touch change with color manipulation through bars) to "int" (containing the color value). With a few additional tweaks the listener does not get notified about the intermediate steps when bars are attached to ColorPicker. Fixes LarsWerkman#60 of the original repository.
sayan-das
approved these changes
Feb 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed return type of all color changing methods (*bar touch changes, circle touch change with color manipulation through bars) to "int" (containing the color value). With a few additional tweaks the listener does not get notified about the intermediate steps when bars are attached to ColorPicker. Solves #60 of the original repository.