Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[en, es] Remove non ASCII apostrophe from email notification. #1789

Merged
merged 1 commit into from
Jun 27, 2021
Merged

[en, es] Remove non ASCII apostrophe from email notification. #1789

merged 1 commit into from
Jun 27, 2021

Conversation

luisprmat
Copy link
Member

Small changes in Laravel that affect our translations

The keys that are becoming obsolete should be removed in future versions of this package, we already have several, among them:

  • If you’re having trouble clicking the ":actionText" button, copy and paste the URL below\ninto your web browser:
  • Login
  • Logout

@caouecs caouecs merged commit 7d68504 into Laravel-Lang:master Jun 27, 2021
@caouecs
Copy link
Member

caouecs commented Jun 27, 2021

Gracias

@emargareten
Copy link

many translations broke with this change

@caouecs
Copy link
Member

caouecs commented Oct 10, 2021

can you explain the problem ?

@emargareten
Copy link

@caouecs I meant laravel/framework#37709 broke all languages.
We just need to add this change/addition to all languages. (just need to copy the value of the original key to the new key)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants