Fix League\CommonMark\Converter::convertToHtml() must be of the type string, null given exception #2353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…string, null given exception Laravel v6.10.0 switched to "league/commonmark instead of erusev/parsedown for mail markdown" league/commonmark doesn't accept null to the parse method. So this small update pass in an empty string if it is null.
|
A new inspection was created. |
|
Okay got from laravel/framework side that they won't change back to previous behaviour of allowing null as they closed my issue so this is good to merge. |
|
Excellent! No idea this was happening. Great drill-down and solution @ziming , thanks a lot! It's now merged and tagged, so a Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Laravel v6.10.0 switched to "league/commonmark instead of erusev/parsedown for mail markdown"
See: laravel/framework#30982
league/commonmark doesn't accept null to the parse method. So this small update pass in an empty string if it is null.
Alternatively someone can make a PR at laravel/framework too to allow accepting null.