style: fix Bad Smells in biz.princeps.lib.command.SubCommand #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aurelien30000
requested review from
Aurelien30000,
rainbowdashlabs and
SirYwell
|
Hey, Thanks for your first contribution. Our team will review this as soon as possible. |
SirYwell
approved these changes
Sep 9, 2022
Aurelien30000
approved these changes
Sep 9, 2022
|
Thank you @MartinWitt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repairing Code Style Issues
SizeReplaceableByIsEmpty
Checking if a something is empty should be done by
Object#isEmptyinstead ofObject.size==0Non-Protected-Constructor-in-Abstract-Class
A non-protected constructor in an abstract class is not needed because only subclasses can be instantiated
Changes:
biz.princeps.lib.command.SubCommand(java.lang.String,java.lang.String,java.util.Set,java.util.Set)is now protected instead of public