Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lua, quest] Convert 'An Explorers Footsteps' to interaction framework #6835

Closed
wants to merge 3 commits into from

Conversation

Grahf0085
Copy link
Contributor

@Grahf0085 Grahf0085 commented Jan 25, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Happy Friday. I had this PR open some time ago but accidentally closed it.

This PR translates the quest "An Explorers Footsteps" to the new quest framework. It also fixes several bugs that have been found in the way the quest is currently implemented. Those bugs are mentioned in the ASB/Horizon issue trackers.

Hookstar provided this capture from someone named Wiggo: https://www.youtube.com/watch?v=XAqdcjoYmuA&list=LL&index=1
He turned in three tablets and I mostly mimic what retail does with a couple exceptions....

For example, when Wiggo turns at stone tablet at 58:54 in the video it's from Konschat Highlands but the Mayor request a tablet from La Theine. The mayor gives the same dialog as every other time Wiggo turned in a stone tablet. I take a different approach and use a cutscene(46) where the Mayor tells you that you gave him the wrong tablet.

Wiggo doesn't capture turning in he same tablet twice. I utilize cutscene 45 if a player tries to turn in the same tablet twice. I believe this is correct.

Fixes these issues:
HorizonFFXI/HorizonXI-Issues#814
AirSkyBoat#2591
AirSkyBoat#2532

There is some talk on the wiki that this quest doesn't count the tablets from Sauromugue Champaign and Batallia Downs towards the 15 required to get the reward of a Map of Crawlers Nest but that isn't in the capture so.... I can try to change that if anyone wants me to.

Steps to test these changes

Accept and complete quest :)

@Grahf0085
Copy link
Contributor Author

One of the biggest problems with the quest now is that the if blocks don't always catch. There are 17! (factorial17), or 3.556×10^14 number of ways to turn in the clay tablets. Lots of those combinations of ways to turn in the clay tablets aren't caught by any if block and you can't progress the quest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant