Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lua] Adjust mob add effect to account for edge cases #6678

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

WinterSolstice8
Copy link
Member

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

No more healing for 4 trillion hp, see comments in code

Steps to test these changes

Get Qoofim to auto attack you until it damages you for < 50, not heals you for 4 trillion

@WinterSolstice8
Copy link
Member Author

Apparently this is in line with item add effects. Item add effects can only generate a bonus, and no penalty. So at least we're consistent after this PR

@zach2good zach2good merged commit 9239268 into LandSandBoat:base Jan 9, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants