Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TakeSwipeLungeDamage, CalculateBaseTP parameter types #6657

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

claywar
Copy link
Contributor

@claywar claywar commented Jan 5, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • TakeSwipeLungeDamage should be CBattleEntity type for Attacker, changed from CCharEntity.
  • CalculateBaseTP had signature mismatch between defined/declared (Declared: int, Defined: int32) for delay. Changed all to int32.
  • Removes declaration for undefined function: CheckMobMultiHits

Steps to test these changes

  • No errors with mob type calling TakeSwipeLungeDamage should occur
  • No other impact to gameplay

TakeSwipeLungeDamage should be CBattleEntity type for Attacker, changed from CCharEntity.

CalculateBaseTP had signature mismatch between defined/declared (Defined: int, Declared: int32) for delay.  Changed all to int32.

Remove undefined function: CheckMobMultiHits
@claywar claywar force-pushed the swipelunge-basetp branch from 0236b19 to d5f0e36 Compare January 5, 2025 13:29
@claywar claywar merged commit a899699 into base Jan 5, 2025
13 checks passed
@claywar claywar deleted the swipelunge-basetp branch January 5, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants