Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lua,sql] Rolanberry Fields NM audit #6582

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

CriticalXI
Copy link
Contributor

@CriticalXI CriticalXI commented Dec 23, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Steps to test these changes

Use !spawnmob to test changes to each NM in game

@CriticalXI
Copy link
Contributor Author

Pending completion of #6566 for proper draw in behavior for Simurgh.

@WinterSolstice8
Copy link
Member

WinterSolstice8 commented Dec 24, 2024

CI is complaining that getMeleeRange isn't defined. I assume that function needs to be ported from ASB too
edit: that might be in the drawin PR

@CriticalXI
Copy link
Contributor Author

That's in the draw in PR that I linked to in my first comment.

@CriticalXI CriticalXI force-pushed the nm_audit_derfland branch 2 times, most recently from c972ee9 to d5f2b5c Compare December 24, 2024 19:54
@CriticalXI CriticalXI force-pushed the nm_audit_derfland branch 2 times, most recently from dd1a608 to 6d88d2f Compare December 28, 2024 21:42
@CriticalXI CriticalXI marked this pull request as ready for review December 28, 2024 21:43
@Xaver-DaRed
Copy link
Contributor

Changes look good to me.

However, could you move the new onMobDespawn sections to be after onMobDeath? That's the usual order.

@CriticalXI
Copy link
Contributor Author

Got that adjusted for all the mobs.

@claywar claywar merged commit e2304a0 into LandSandBoat:base Jan 1, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants