Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interaction - Battlefields: Monarch Linn, La Vaule, Riverne B01 #5853

Merged
merged 4 commits into from
May 31, 2024

Conversation

claywar
Copy link
Contributor

@claywar claywar commented May 30, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Converts the following battlefields to Interaction framework:

  • Storms of Fate
  • The Savage
  • Ancient Vows
  • Purple, The New Black

Also removes additional unused BCNM code, separates Spatial Displacement NPCs in Monarch Linn, and corrects Bahamut spawn position.

Steps to test these changes

Enter/win/exit/lose the above battlefields

claywar added 4 commits May 30, 2024 08:03
Fix level restriction, index

Remove unused code from bcnm.lua
Remove unused bcnm code
Fix IDs, mob spawn point, area format

Remove duplicate title grant
@claywar claywar merged commit fd3fa5e into base May 31, 2024
12 checks passed
@claywar claywar deleted the interaction/more-battlefields branch May 31, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants