[Quest]A Minstrel in Despair to IF #5824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zach2good
requested changes
May 27, 2024
| -- Log ID: 3, Quest ID: 12 | ||
| -- Mertaire : !pos -17 0 -61 245 | ||
| ----------------------------------- | ||
| local quest = Quest:new(xi.questLog.JEUNO, xi.quest.id.jeuno.A_MINSTREL_IN_DESPAIR) |
There was a problem hiding this comment.
This isn't a hidden quest, since it is tracked by a quest log entry. All the hidden quests DONT have a quest entry at any time, and are tracked by char vars (local quest = HiddenQuest:new('TrustIngrid') etc.).
This one is only slightly different in that it isn't visible until it's complete. Move it to the jeuno folder.
Presumably because it's only a single step and it doesn't contain quest:begin it should act like the wikis say
There was a problem hiding this comment.
That's a great point. It is in the right place on my implementation on hxi and asb - must have saw hidden and then put in hidden quest. Thanks, moved.
[quest]Move to Jeuno Co-Authored-By: Abdiah <[email protected]> Co-Authored-By: Critical <[email protected]>
hooksta4
force-pushed
the
minstrel_in_despair
branch
from
f522f63 to
ba7864d
Compare
zach2good
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Converts A Minstrel In Despair to IF. Places it in the hiddenQuests.
Steps to test these changes
Complete The Old Monument. Trade the Poetic Parchment to Mertaire.
Quest will now show as completed in log.