Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gear Update #1896

Merged
merged 6 commits into from Jun 8, 2022
Merged

Gear Update #1896

merged 6 commits into from Jun 8, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jun 7, 2022

Added in gear updates for lvl 99, Missing Mods, Equipment

I affirm:

  • I have paid attention to this example and will edit again if need be to not break the formatting, or I will be ignored
  • I have read and understood the Contributing Guide
  • I've tested my code and the things my code has changed since the last commit in the PR, and will test after any later commits

What does this pull request do?

Adds missing gear, for Mods and Equipment

Steps to test these changes

Fixed the missing gear for lvl 99

Added in gear updates for lvl 99, Missing Mods, Equipment
Copy link
Contributor

@TeoTwawki TeoTwawki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sql data should be arranged in order of the tables primary key(s) for the respective tables.

in the item_equipment table I see some of it was out of order before you got here. Ordering it proper would be welcomed.

@ghost
Copy link
Author

ghost commented Jun 7, 2022

sql data should be arranged in order of the tables primary key(s) for the respective tables.

in the item_equipment table I see some of it was out of order before you got here. Ordering it proper would be welcomed.

Ok working on fixing that

@WinterSolstice8
Copy link
Member

Good work, thanks for the effort in making this.

Update locations for the gear
@ghost
Copy link
Author

ghost commented Jun 7, 2022

Good work, thanks for the effort in making this.

Thanks, just trying to help out so able to have stuff for lvl 99

@ghost ghost requested a review from TeoTwawki June 7, 2022 04:26
Xsoulsin added 2 commits June 7, 2022 01:08
Updated what some of the gear Mod is and fixed Crepuscular Scythe "0"
Fixed Whitespace Error and added in more description mods
@ghost ghost requested a review from Xaver-DaRed June 7, 2022 16:32
Updated missing mod description
@ghost
Copy link
Author

ghost commented Jun 8, 2022

Ok updated the missing mod descriptions. Hopefully it is ready to go

@WinterSolstice8
Copy link
Member

Can you address my previous comments about Epeolatry, Srivatsa, and Lionheart? you're very close!

@ghost
Copy link
Author

ghost commented Jun 8, 2022

@WinterSolstice8 I am more happy to update them but I was not able to find the comment. Maybe I am over looking it

sql/item_mods.sql Outdated Show resolved Hide resolved
sql/item_mods.sql Outdated Show resolved Hide resolved
sql/item_mods.sql Outdated Show resolved Hide resolved
sql/item_mods.sql Outdated Show resolved Hide resolved
sql/item_mods.sql Outdated Show resolved Hide resolved
sql/item_mods.sql Outdated Show resolved Hide resolved
sql/item_mods.sql Outdated Show resolved Hide resolved
@WinterSolstice8
Copy link
Member

WinterSolstice8 commented Jun 8, 2022

@WinterSolstice8 I am more happy to update them but I was not able to find the comment. Maybe I am over looking it

My bad, I just got contributor status for the first time on any repo and apparently I had to click the "submit review" button. Sorry! not your fault -- this is my first "official" review with changes

@ghost
Copy link
Author

ghost commented Jun 8, 2022

@WinterSolstice8 I am more happy to update them but I was not able to find the comment. Maybe I am over looking it

My bad, I just got contributor status for the first time on any repo and apparently I had to click the "submit review" button. Sorry! not your fault -- this is my first "official" review with changes

Ok no worries. ya I can update them. give me some time and I will double check em

Updated positon for Godhands and some mods
Copy link
Member

@WinterSolstice8 WinterSolstice8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! thanks!

@ghost
Copy link
Author

ghost commented Jun 8, 2022

Looks good to me! thanks!

Ok thanks. I didn't know I mistake had them outta order, and forgot few things. But in next PR make sure all in line

Copy link
Contributor

@TeoTwawki TeoTwawki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming mods are correct (I can't personally verify them all) then when the author is finished with any further comments it's good to me.

@ghost
Copy link
Author

ghost commented Jun 8, 2022

If anything else needs updated I can do.

@claywar claywar merged commit 2ac8016 into LandSandBoat:base Jun 8, 2022
@ghost ghost deleted the Gear-Updates branch June 8, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants