Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUN] Implement Foil; [lua] fix accuracy calculation for mob TP moves #1759

Merged
merged 3 commits into from
May 20, 2022

Conversation

WinterSolstice8
Copy link
Member

After a truly herculean amount of testing, nerding with some other more qualified math nerds...

I affirm:

  • I have paid attention to this example and will edit again if need be to not break the formatting, or I will be ignored
  • I have read and understood the Contributing Guide
  • I've tested my code and the things my code has changed since the last commit in the PR, and will test after any later commits

What does this pull request do?

Implement Foil's Special Attack evasion for mob TP moves only.
Fix accuracy calculation for mob TP moves.

Steps to test these changes

Foil potency:

  1. !changejob RUN 99
  2. cast foil
  3. !getmod SPECIAL_ATTACK_EVASION, it should be 150 on first tick
  4. re-issue !getmod to verify it ticks down by 3 every tick
  5. verify mod is 0 when foil wears off naturally
  6. verify mod is 0 when foil is cancelled manually

Verify Special Attack Evasion:
find a mob that has good accuracy against you on physical TP moves

  1. target yourself, !setmod SPECIAL_ATTACK_EVASION 9999
  2. target mob, !tp 3000 repeatedly for TP moves
  3. note mob constantly misses
  4. target yourself, !setmod SPECIAL_ATTACK_EVASION 0
  5. reissue !tp 3000 on mob, note it can hit you well enough again

@zach2good zach2good merged commit bb569bc into LandSandBoat:base May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants