Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUN] Add core mods for Rune Fencer #1353

Merged
merged 1 commit into from
Mar 2, 2022
Merged

[RUN] Add core mods for Rune Fencer #1353

merged 1 commit into from
Mar 2, 2022

Conversation

zach2good
Copy link
Contributor

I affirm:

  • I have paid attention to this example and will edit again if need be to not break the formatting, or I will be ignored
  • that I agree to LandSandBoat's Limited Contributor License Agreement, as written on this date
  • that I have read the Contributing Guide
  • that I've tested my code and things my code changed since the last commit in the PR, and will test after any later commits

@zach2good
Copy link
Contributor Author

I don't know anything about Rune Fencer, let me know if we should rename these, add things etc.

@WinterSolstice8
Copy link
Member

Inquartata can stay as "Inquartata", it's not a RUN specific thing, though it's their "featured trait" much like Fast Cast and RDM. BLU can get it as a trait via SOA spells and there's a couple gear slots that add it directly. Just like Fast Cast, +1 = +1%.

I forgot that SE went on a standardization of bonuses for new gear and to not hide effects, so things like 'Enhances "Fast Cast" Effect' got changed to show their real values/effects. So I should've looked at the +3 versions not the NQs for effect names...
ENHANCES_PFLUG -> PFLUG is just a direct % bonus added to the base % effect
ENHANCES_VALIANCE_VALLATION -> VALIANCE_VALLATION_DURATION
ENHANCES_VIVACIOUS_PULSE-> VIVACIOUS_PULSE_POTENCY

double checked for more RUN specific stuff in JSE/augs/ambuscade gear to be added:
RAYKE_DURATION
ODYLLIC_SUBTERFUGE_DURATION
SWIPE
LIEMENT_DURATION
GAMBIT_DURATION
EMBOLDEN_DURATION
LIEMENT_EXTENDS_TO_AREA <- this one is a RUN "mythic weapon" bonus, I don't know if this effect should go somewhere else. There is also the same mythic weapon hidden % bonus to the associated weapon skill, Dimidiation
I can't find any more but it should cover most bases

@zach2good
Copy link
Contributor Author

Okidoki, updated. If we need to add more later it isn't a problem 👍

@WinterSolstice8
Copy link
Member

Looks perfect to me. Thanks a ton for this!

@zach2good zach2good merged commit 240b081 into base Mar 2, 2022
@zach2good zach2good deleted the runefencer_mods branch March 2, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants