-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.1.0 #114
Merged
Merged
Version 1.1.0 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync with main
…cate-caching [#88] Removed redundant cache, removed cacheInfoOldContentPack
…et similar workflows
…-manipulator-tool Feature/issue 103 reactivate manipulator tool
…caling-experimental' into feature/issue-108-dynamic-item-scaling-experimental # Conflicts: # src/main/java/net/landofrails/landofsignals/contentpacks/ContentPackHandler.java
…-magnifying-glass [#106] Added magnifyingglass (first attempt)
…exsignal-can-not-be-loaded-correctly-when-added-into-a-contentset [#109] Fixed issues with ContentPackComplexSignal
…em-scaling-experimental Feature/issue 108 dynamic item scaling experimental
issue-112 version set to 1.1.0
…1.1.0 [#112] Set version to 1.1.0 and updated CHANGELOG.md
Danielxs01
added
enhancement
New feature or request
Stellwand
Problem belongs to the stellwand part
Signals
Problem belongs to the signals part
Priority: Normal
Indicates that the issue or enhancement is of normal priority
code improvement
Improvements in performance and code quality
Forge (all versions)
labels
Jul 27, 2023
MarkenJaden
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool new features!
I noticed in the TileSignalPart "refreshSignals" and "updateSignals" is somehow a bit confusing from the functions, but that is not particularly important.
And as written the two config options I would set to true by default.
src/main/java/net/landofrails/landofsignals/configs/LandOfSignalsConfig.java
Show resolved
Hide resolved
src/main/java/net/landofrails/landofsignals/configs/LandOfSignalsConfig.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
code improvement
Improvements in performance and code quality
enhancement
New feature or request
Forge (all versions)
Priority: Normal
Indicates that the issue or enhancement is of normal priority
Signals
Problem belongs to the signals part
Stellwand
Problem belongs to the stellwand part
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.