Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UMC 1.2.0] Add support for flares/lighting #133

Open
Danielxs01 opened this issue Dec 10, 2023 · 3 comments
Open

[UMC 1.2.0] Add support for flares/lighting #133

Danielxs01 opened this issue Dec 10, 2023 · 3 comments
Assignees
@Danielxs01
Labels
enhancement New feature or request Forge (all versions) help wanted Extra attention is needed Priority: High Indicates that the issue or enhancement is of high priority Signals Problem belongs to the signals part

Comments

@Danielxs01
Copy link
Member

[Testbuild] Add support for flares/lighting
@Danielxs01 Danielxs01 added enhancement New feature or request help wanted Extra attention is needed Forge 1.12.2 Signals Problem belongs to the signals part Priority: Normal Indicates that the issue or enhancement is of normal priority labels Dec 10, 2023
@Danielxs01 Danielxs01 self-assigned this Dec 10, 2023
@cam72cam
Copy link
Collaborator

Ping me here or on discord if you would like any assistance!

Danielxs01 added a commit that referenced this issue Dec 11, 2023
@Danielxs01
[#133] Added import for testbuild (1.1.4-f2e4281)
a9922b6
Danielxs01 added a commit that referenced this issue Dec 14, 2023
@Danielxs01
[#133] Added model with light_flare element
ef11dbe
Danielxs01 added a commit that referenced this issue Dec 14, 2023
@Danielxs01
[#133] Added new model to LOSBlocks.java
f582026
Danielxs01 added a commit that referenced this issue Dec 14, 2023
@Danielxs01
[#133] Added POC implementation of the light flares
bd1c7ec
Danielxs01 added a commit that referenced this issue Dec 14, 2023
@Danielxs01
[#133] main.yml only build 1.12.2
9a691a2
Danielxs01 added a commit that referenced this issue Dec 15, 2023
@Danielxs01
[#133] Implemented basic flare.
8d91caa 
=> Currently no cone
=> Can already be implemented via contentpack
=> Added some caching for the flares, should be extended later on
Danielxs01 added a commit that referenced this issue Dec 16, 2023
@Danielxs01
[#133] Added second flare to test model
4fa5580
Danielxs01 added a commit that referenced this issue Dec 16, 2023
@Danielxs01
[#133] Implemented scaling - (!) not fully tested.
aff21c9
Danielxs01 added a commit that referenced this issue Dec 20, 2023
@Danielxs01
[#133] Changed to latest UMC.
2f7bc01
Danielxs01 added a commit that referenced this issue Dec 26, 2023
@Danielxs01
[#133] Finished intensity calculation. Removed intensity and added of…
d2c0260 
…fset as parameter.
@Danielxs01 Danielxs01 changed the title [Testbuild] Add support for flares/lighting [UMC 1.2.0] Add support for flares/lighting Jan 17, 2024
@Danielxs01
Copy link
Member Author

Danielxs01 commented Jan 17, 2024 •
edited
Loading

PoC finished with commit: 2b647ce

Open TODOs

Signals

  • Move rotation, offset and pitch to contentpack-entry and remove it from obj-group
  • Add ability to state multiple obj-groups / remove need for "lightflare"-group
  • Implement always-on
  • Add caching
  • Add preloading
  • Add support for blocks modified with the manipulator tool (Difficulty: Severely depressing)

Complex signals

  • Implement flares
  • Add caching
  • Add preloading

Signs

  • Implement flares
  • Add caching
  • Add preloading

Assets

  • Implement flares
  • Add caching
  • Add preloading

Levers

  • Implement flares
  • Add caching
  • Add preloading

Others

  • Create documentation
  • Provide test build in discord and wait for responses
  • Create release 1.4.0

@Danielxs01 Danielxs01 added Forge (all versions) Priority: High Indicates that the issue or enhancement is of high priority and removed Forge 1.12.2 Priority: Normal Indicates that the issue or enhancement is of normal priority labels Jan 18, 2024
Danielxs01 added a commit that referenced this issue Jan 18, 2024
@Danielxs01
[#133] Move rotation, offset and pitch to contentpack-entry and remov…
739217f 
…e it from obj-group
Danielxs01 added a commit that referenced this issue Jan 18, 2024
@Danielxs01
[#133] Add ability to state multiple obj-groups / remove need for "li…
c17ad5e 
…ghtflare"-group
Danielxs01 added a commit that referenced this issue Jan 18, 2024
@Danielxs01
[#133] Add ability to state multiple obj-groups / remove need for "li…
9a37cc5 
…ghtflare"-group
Danielxs01 added a commit that referenced this issue Jan 18, 2024
@Danielxs01
[#133] Implement always-on
20df31f
Danielxs01 added a commit that referenced this issue Jan 18, 2024
@Danielxs01
[#133] Add caching (not my proudest work)
7fa2dc7
Danielxs01 added a commit that referenced this issue Jan 22, 2024
@Danielxs01
[#133] Add preloading
3ec1337
Danielxs01 added a commit that referenced this issue Jan 22, 2024
@Danielxs01
[#133] Added tooltip ("Has flares: true/false")
aac3fb9
Danielxs01 added a commit that referenced this issue Jan 22, 2024
@Danielxs01
[#133] Flares can now be rotated and offset (not scaled though)
c0c2d44
Danielxs01 added a commit that referenced this issue Jan 22, 2024
@Danielxs01
[#133] Scaling works now. Easier than I thought
a65e679
Danielxs01 added a commit that referenced this issue Feb 24, 2024
@Danielxs01
[#133] WIP: Flares now have the correct height even if block is large…
e84ffaf 
…r or smaller than 1 block
Danielxs01 added a commit that referenced this issue Feb 25, 2024
@Danielxs01
[#133] Changed color to red for SH2 flares
0c52c35
Danielxs01 added a commit that referenced this issue Feb 29, 2024
@Danielxs01
[#133] Height-calculation adjustments - end of this iteration
6b47d9d
Danielxs01 added a commit that referenced this issue Feb 29, 2024
@Danielxs01
[#133] Height-calculation adjustments - (small correction)
56186ca
Danielxs01 added a commit that referenced this issue Mar 3, 2024
@Danielxs01
[#133] Use center of model for offset correction
127ffac
Danielxs01 referenced this issue Apr 17, 2024
@Danielxs01
[#157] Split offset into preOffset and postOffset to correct issues w…
68d1683 
…ith different rotations.
@Danielxs01
Copy link
Member Author

Danielxs01 commented Apr 17, 2024 •
edited
Loading

  • Fix mentioned issue.

Danielxs01 added a commit that referenced this issue Apr 19, 2024
@Danielxs01
[#133] Fixed playerOffset now uses preOffset instead of postOffset
5840119
Danielxs01 added a commit that referenced this issue Apr 19, 2024
@Danielxs01
[#133] Fixed inverted flare position if position wasn't centered.
c71c94f
Danielxs01 added a commit that referenced this issue Apr 28, 2024
@Danielxs01
[#133] Added texture option to flares
46e2584
Danielxs01 added a commit that referenced this issue May 5, 2024
@Danielxs01
[#133] Fixed flares being rotated upside down
675945c
Danielxs01 added a commit that referenced this issue May 5, 2024
@Danielxs01
[#133] Added scaleWithDistance (boolean)
9e78632
Danielxs01 added a commit that referenced this issue May 16, 2024
@Danielxs01
[#133] Added flares to Deco, Sign and Lever
e6a90ff
Danielxs01 added a commit that referenced this issue Jun 10, 2024
@Danielxs01
[#133] Implemented objPathIndex
863e2b4
@github-project-automation github-project-automation bot moved this to To do in Signals Aug 30, 2024
@github-project-automation github-project-automation bot moved this to To do in Assets Aug 30, 2024
Danielxs01 added a commit that referenced this issue Sep 27, 2024
@Danielxs01
[#133] ComplexSignals can display flares. Attributes "postRotation" a…
ed015dd 
…nd "scalingMultiplier" added to flares for better fine-tuning for complex signals.

Added validation / default values for flares.
Danielxs01 added a commit that referenced this issue Sep 28, 2024
@Danielxs01
[#133] Added "Has flares:" tooltip to every affected item
c2107b7
Danielxs01 added a commit that referenced this issue Sep 28, 2024
@Danielxs01
[#133] FlareUtils: Using objPathIndex instead of first entry (0)
e669c2f
Danielxs01 added a commit that referenced this issue Sep 28, 2024
@Danielxs01
[#133] Disabled "scaleWithDistance" by default
cc35f97
Danielxs01 added a commit that referenced this issue Sep 28, 2024
@Danielxs01
[#133] Added flares to GSAR sign LF1
d72e49c
Danielxs01 added a commit that referenced this issue Oct 7, 2024
@Danielxs01
[#133] Starting of ContentPacksV2_StepByStep.md
76c1be9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Danielxs01 Danielxs01

Labels
enhancement New feature or request Forge (all versions) help wanted Extra attention is needed Priority: High Indicates that the issue or enhancement is of high priority Signals Problem belongs to the signals part
Projects
Assets
Status: To do
Signals
Status: To do
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

feature/issue-133-testbuild-add-support-for-flareslighting LandOfRails/LandOfSignals
2 participants
@cam72cam @Danielxs01