Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dot-4171] feat: add locators if they are in page's range #172

Merged
merged 5 commits into from
Nov 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@lambdatest/smartui-cli",
"version": "4.0.10",
"version": "4.0.11",
"description": "A command line interface (CLI) to run SmartUI tests on LambdaTest",
"files": [
"dist/**/*"
Expand Down
48 changes: 42 additions & 6 deletions src/lib/processSnapshot.ts
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,31 @@ export default async function processSnapshot(snapshot: Snapshot, ctx: Context):
throw new Error(`for snapshot ${snapshot.name} viewport ${viewportString}, multiple elements found for selector ${processedOptions.element}`);
}
} else if (selectors.length) {
let height = 0;
height = await page.evaluate(() => {
const DEFAULT_HEIGHT = 16384;
const body = document.body;
const html = document.documentElement;
if (!body || !html) {
ctx.log.debug('Document body or html element is missing, using default height');
return DEFAULT_HEIGHT;
}
const measurements = [
body?.scrollHeight || 0,
body?.offsetHeight || 0,
html?.clientHeight || 0,
html?.scrollHeight || 0,
html?.offsetHeight || 0
];
const allMeasurementsInvalid = measurements.every(measurement => !measurement);
if (allMeasurementsInvalid) {
ctx.log.debug('All height measurements are invalid, using default height');
return DEFAULT_HEIGHT;
}
return Math.max(...measurements);
});
ctx.log.debug(`Calculated content height: ${height}`);

let locators: Array<Locator> = [];
if (!Array.isArray(processedOptions[ignoreOrSelectBoxes][viewportString])) processedOptions[ignoreOrSelectBoxes][viewportString] = []

Expand All @@ -314,12 +339,23 @@ export default async function processSnapshot(snapshot: Snapshot, ctx: Context):
}
for (const locator of locators) {
let bb = await locator.boundingBox();
if (bb) processedOptions[ignoreOrSelectBoxes][viewportString].push({
left: bb.x,
top: bb.y,
right: bb.x + bb.width,
bottom: bb.y + bb.height
});
if (bb) {
// Calculate top and bottom from the bounding box properties
const top = bb.y;
const bottom = bb.y + bb.height;

// Only push if top and bottom are within the calculated height
if (top <= height && bottom <= height) {
processedOptions[ignoreOrSelectBoxes][viewportString].push({
left: bb.x,
top: top,
right: bb.x + bb.width,
bottom: bottom
});
} else {
ctx.log.debug(`Bounding box for selector skipped due to exceeding height: ${JSON.stringify({ top, bottom, height })}`);
}
}
}
}
ctx.log.debug(`Processed options: ${JSON.stringify(processedOptions)}`);
Expand Down