Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to polkadot-v0.9.27 #51

Merged
merged 9 commits into from
Aug 23, 2022
Merged

Update to polkadot-v0.9.27 #51

merged 9 commits into from
Aug 23, 2022

Conversation

@realnimish realnimish requested a review from extraymond August 22, 2022 14:55
Copy link
Contributor

@extraymond extraymond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have question about changing into_account to into_account_truncating, while it might works since we're just getting the account_id from PalletId,

Semantically into_account().expect("infailable") should be better.

pallets/contract-asset-registry/src/lib.rs Outdated Show resolved Hide resolved
@realnimish realnimish requested a review from extraymond August 23, 2022 07:12
@realnimish realnimish merged commit c11e543 into main Aug 23, 2022
@realnimish realnimish deleted the bump-polkadot-v0.9.27 branch September 2, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants