Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add agerapvp, lastcraft, fakepixel #1689

Merged
merged 10 commits into from
Feb 10, 2025
Merged

add agerapvp, lastcraft, fakepixel #1689

merged 10 commits into from
Feb 10, 2025

Conversation

Krashe85
Copy link
Contributor

@Krashe85 Krashe85 commented Feb 6, 2025

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Remove directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately (e.g. on https://tinypng.com)
  • I have created the manifest.json with the required values

Further comments

Copy link

github-actions bot commented Feb 6, 2025

Just as an information regarding your wildcards:

  • Wildcard %.agerapvp.club seems to be invalid. Server is offline with testing wildcard.
  • Wildcard %.agerapvp.net seems to be invalid. Server is offline with testing wildcard.

Please make sure it is an actual wildcard.

Copy link

github-actions bot commented Feb 6, 2025

Just as an information regarding your wildcards:

  • Wildcard %.fakepixel.fun seems to be invalid. Server is offline with testing wildcard.

Please make sure it is an actual wildcard.

Copy link

github-actions bot commented Feb 6, 2025

Just as an information:
Your server play.play-craft.net could be offline.
In general, we only accept pull requests from servers, that are online.
Please change this, otherwise we cannot review your server correctly and have to deny the pull request.

Reference: API URL (https://api.mcstatus.io/v2/status/java/play.play-craft.net?query=false)

Copy link

github-actions bot commented Feb 6, 2025

Just as an information regarding your wildcards:

  • Wildcard %.lastcraft.net seems to be invalid. Server is offline with testing wildcard.
  • Wildcard %.last-craft.net seems to be invalid. Server is offline with testing wildcard.

Please make sure it is an actual wildcard.

Copy link

github-actions bot commented Feb 6, 2025

Just as an information:

Copy link

github-actions bot commented Feb 6, 2025

Just as an information regarding your wildcards:

  • Wildcard %.agerapvp.club seems to be invalid. Server is offline with testing wildcard.
  • Wildcard %.agerapvp.net seems to be invalid. Server is offline with testing wildcard.

Please make sure it is an actual wildcard.

Copy link

github-actions bot commented Feb 6, 2025

Just as an information regarding your wildcards:

  • Wildcard %.fakepixel.fun seems to be invalid. Server is offline with testing wildcard.

Please make sure it is an actual wildcard.

Copy link

github-actions bot commented Feb 6, 2025

Just as an information:
Your server play.play-craft.net could be offline.
In general, we only accept pull requests from servers, that are online.
Please change this, otherwise we cannot review your server correctly and have to deny the pull request.

Reference: API URL (https://api.mcstatus.io/v2/status/java/play.play-craft.net?query=false)

Copy link

github-actions bot commented Feb 6, 2025

Just as an information regarding your wildcards:

  • Wildcard %.lastcraft.net seems to be invalid. Server is offline with testing wildcard.
  • Wildcard %.last-craft.net seems to be invalid. Server is offline with testing wildcard.

Please make sure it is an actual wildcard.

Copy link

github-actions bot commented Feb 6, 2025

Just as an information:

Copy link

github-actions bot commented Feb 6, 2025

Just as an information regarding your wildcards:

  • Wildcard %.agerapvp.club seems to be invalid. Server is offline with testing wildcard.
  • Wildcard %.agerapvp.net seems to be invalid. Server is offline with testing wildcard.

Please make sure it is an actual wildcard.

Copy link

github-actions bot commented Feb 6, 2025

Just as an information regarding your wildcards:

  • Wildcard %.fakepixel.fun seems to be invalid. Server is offline with testing wildcard.

Please make sure it is an actual wildcard.

Copy link

github-actions bot commented Feb 6, 2025

Just as an information:
Your server play.play-craft.net could be offline.
In general, we only accept pull requests from servers, that are online.
Please change this, otherwise we cannot review your server correctly and have to deny the pull request.

Reference: API URL (https://api.mcstatus.io/v2/status/java/play.play-craft.net?query=false)

Copy link

github-actions bot commented Feb 6, 2025

Just as an information regarding your wildcards:

  • Wildcard %.lastcraft.net seems to be invalid. Server is offline with testing wildcard.
  • Wildcard %.last-craft.net seems to be invalid. Server is offline with testing wildcard.

Please make sure it is an actual wildcard.

Copy link

github-actions bot commented Feb 6, 2025

Just as an information regarding your wildcards:

  • Wildcard %.agerapvp.club seems to be invalid. Server is offline with testing wildcard.
  • Wildcard %.agerapvp.net seems to be invalid. Server is offline with testing wildcard.

Please make sure it is an actual wildcard.

Copy link

github-actions bot commented Feb 6, 2025

Just as an information regarding your wildcards:

  • Wildcard %.fakepixel.fun seems to be invalid. Server is offline with testing wildcard.

Please make sure it is an actual wildcard.

Copy link

github-actions bot commented Feb 6, 2025

Just as an information:
Your server play.play-craft.net could be offline.
In general, we only accept pull requests from servers, that are online.
Please change this, otherwise we cannot review your server correctly and have to deny the pull request.

Reference: API URL (https://api.mcstatus.io/v2/status/java/play.play-craft.net?query=false)

Copy link

github-actions bot commented Feb 6, 2025

Just as an information regarding your wildcards:

  • Wildcard %.lastcraft.net seems to be invalid. Server is offline with testing wildcard.
  • Wildcard %.last-craft.net seems to be invalid. Server is offline with testing wildcard.

Please make sure it is an actual wildcard.

Copy link

github-actions bot commented Feb 6, 2025

Just as an information:
Your server play.play-craft.net could be offline.
In general, we only accept pull requests from servers, that are online.
Please change this, otherwise we cannot review your server correctly and have to deny the pull request.

Reference: API URL (https://api.mcstatus.io/v2/status/java/play.play-craft.net?query=false)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

Copy link

github-actions bot commented Feb 6, 2025

Just as an information regarding your wildcards:

  • Wildcard %.agerapvp.club seems to be invalid. Server is offline with testing wildcard.
  • Wildcard %.agerapvp.net seems to be invalid. Server is offline with testing wildcard.

Please make sure it is an actual wildcard.

Copy link

github-actions bot commented Feb 6, 2025

Just as an information regarding your wildcards:

  • Wildcard %.fakepixel.fun seems to be invalid. Server is offline with testing wildcard.

Please make sure it is an actual wildcard.

Copy link

github-actions bot commented Feb 6, 2025

Just as an information regarding your wildcards:

  • Wildcard %.lastcraft.net seems to be invalid. Server is offline with testing wildcard.
  • Wildcard %.last-craft.net seems to be invalid. Server is offline with testing wildcard.

Please make sure it is an actual wildcard.

"nice_name": "AgeraPvP Club",
"direct_ip": "mc.agerapvp.club",
"server_wildcards": [
"%.agerapvp.club",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot join with wildcard

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several ip's on the *.agerapvp.club domains: mc/play and other. Should I add only them ?

"direct_ip": "mc.agerapvp.club",
"server_wildcards": [
"%.agerapvp.club",
"%.agerapvp.net"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot join with wildcard

"nice_name": "Fakepixel Network",
"direct_ip": "mc.fakepixel.fun",
"server_wildcards": [
"%.fakepixel.fun"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot join with wildcard

"nice_name": "LastCraft",
"direct_ip": "play.last-craft.net",
"server_wildcards": [
"%.lastcraft.net",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot join with wildcard

"direct_ip": "play.last-craft.net",
"server_wildcards": [
"%.lastcraft.net",
"%.last-craft.net"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot join with wildcard

"en"
],
"social": {
"web": "https://agerapvp.club",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Website is only shop, remove

"social": {
"web": "https://fakepixel.fun",
"web_shop": "https://world.fakepixel.shop",
"web_support": "https://support.fakepixel.fun",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot be Discord invite (redirect); remove or add FAQ/contact form

"%.last-craft.net"
],
"social": {
"web": "https://last-craft.net",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Website is shop; remove

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

@Krashe85 Krashe85 requested a review from DoJapHD February 9, 2025 23:03
@DoJapHD DoJapHD merged commit 30a7787 into LabyMod:master Feb 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants