Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 59 Updated #63

Merged
merged 1 commit into from
Aug 17, 2018
Merged

Fix Issue 59 Updated #63

merged 1 commit into from
Aug 17, 2018

Conversation

agomez08
Copy link
Contributor

Fixing issue 59. Modified runtme class to keep a count of the slaves connected to the same instance of a Modbus Master. We avoid shutting down this instance until there are not more slaves connected to the same Master instance. With this approach we avoid that failure in the ##connection with one Slave causes the rest of connections to fail as well.
#59

…same instance of a Modbus Master. We avoid shutting down this instance until there are not more slaves connected to the same Master instance. With this approach we avoid that failure in the connection with one Slave causes the rest of connections to fail as well.
@agomez08 agomez08 changed the title Fix Issue 59 Fix Issue 59 Updated Aug 17, 2018
@DCAF-Builder
Copy link
Contributor

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Modbus Module runtime.lvclass--close.vi.png: capture

Modbus Module runtime.lvclass--Decrement Clients Count.vi.png: capture

Modbus Module runtime.lvclass--Increment Clients Count.vi.png: capture

Modbus Module runtime.lvclass--init.vi.png: capture

Modbus Module runtime.lvclass--modbus initialize API object.vi.png: capture

@becega becega self-requested a review August 17, 2018 21:31
Copy link
Contributor

@becega becega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants