Set qcTraceName on ChromatogramGroupId #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nickshulman & @josheckels This PR does not set the SpectrumClassFilter on ChromatogramGroupId. Looks like that was added in this PR: #921, but it was merged with "develop" in July so it is not part of 24.7-SNAPSHOT that we just deployed on PanoramaWeb. |
|
@vagisha yes, I think we can back port all of Nick's change to 24.7. We're lucky here that 24.7 already has 24.004 as the schema version for |
"Spectrum Filter" gets parsed from the Skyline document light:heavy ratios are not calculated for precursors that have a spectrum filter The spectrum filter is used when deciding which chromatogram to read from the .skyd file for a particular precursor. # Conflicts: # src/org/labkey/targetedms/parser/ChromatogramGroupId.java
… and spectrumFilter.
|
@labkey-jeckels changes have been backported. Waiting for tests to pass. |
labkey-jeckels
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
qcTraceName is written to the skyd file but was not being set on ChromatogramGroupId in the Panorama code.
If the name of a QC trace is empty, it cannot be used to create a trace metric in QC folders (https://www.labkey.org/issues/home/Developer/issues/details.view?issueId=50773).
Related Pull Requests
Changes